New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just delay select.epoll
to fix import after gevent monkey patching
#2928
base: master
Are you sure you want to change the base?
Conversation
select.epoll
to fix import with gevent monkey patchingselect.epoll
to fix import after gevent monkey patching
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2928 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 117 117
Lines 17594 17594
Branches 3171 3172 +1
=======================================
Hits 17532 17532
Misses 43 43
Partials 19 19
|
cc @jeongilpark could you see if this works for you? I'm not sure if you're actually ending up using trio. (if you do, maybe we should do a better solution, like... I don't know, maybe use |
@jakkdl @CoolCat467 - is this issue and the one specifically listed below resolved now? |
no? I don't see any reason why they've would've been fixed with no changes to any code. |
This seems to work:
Fixes: #2848
... While trio still doesn't work under gevent, I think not erroring when importing is a good property to have.