Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use uv pip install #2957

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

CoolCat467
Copy link
Contributor

This pull request follows up on #2956 and is attempting to switch the continuous integration system to use astral.sh' new tool uv.

@CoolCat467 CoolCat467 added the dependencies Pull requests that update a dependency file label Feb 16, 2024
@CoolCat467 CoolCat467 marked this pull request as draft February 16, 2024 02:52
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (7dbbac9) to head (bb1ba35).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2957      +/-   ##
==========================================
- Coverage   99.63%   94.05%   -5.58%     
==========================================
  Files         117      117              
  Lines       17593    17593              
  Branches     3173     3173              
==========================================
- Hits        17528    16547     -981     
- Misses         46      975     +929     
- Partials       19       71      +52     

see 33 files with indirect coverage changes

@A5rocks
Copy link
Contributor

A5rocks commented Feb 16, 2024

This seems nontrivial, can we break this into 2 prs?

  1. replace pip-compile
  2. replace pip install

Personally I see (1) as much more valuable-- (2) doesn't change much. Personally I'm more excited by uv's ability to get the lowest compatible version so we can add a new CI run than by it replacing pip install.

@CoolCat467 CoolCat467 changed the title Switch to use uv. Closes #2956 Switch to use uv pip install Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants