Enable ruff's Perflint rule. #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2969 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 117 117
Lines 17593 17578 -15
Branches 3173 3172 -1
==========================================
- Hits 17528 17513 -15
Misses 46 46
Partials 19 19
|
A5rocks
reviewed
Mar 11, 2024
src/trio/_subprocess.py
Outdated
| @@ -723,7 +723,7 @@ async def read_output( | |||
| ) -> None: | |||
| async with stream: | |||
| async for chunk in stream: | |||
| chunks.append(chunk) | |||
| chunks.append(chunk) # noqa: PERF402 | |||
There was a problem hiding this comment.
I feel like PERF402 on an argument passed in is incorrect and probably is a bug...
There was a problem hiding this comment.
Created astral-sh/ruff#11316 for this
Co-authored-by: EXPLOSION <git@helvetica.moe>
TeamSpen210
reviewed
Mar 11, 2024
Co-authored-by: Spencer Brown <spencerb21@live.com>
TeamSpen210
reviewed
Mar 15, 2024
Co-authored-by: Spencer Brown <spencerb21@live.com>
|
Updating branch to see if any changes with new ruff versions |
|
pre-commit.ci autofix |
A5rocks
approved these changes
May 16, 2024
|
Given that astral-sh/ruff#11316 is still open, I am thinking of merging this soon unless anyone has any other comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables ruff's perflint rule and handles the associated fixes or ignores.