fix: set change during iteration when dispatching listeners #4379

You have commit messages with errors ⧗ input: fix: set change during iteration when dispatching listeners An existing listener may add new listeners to process ServiceInfo when it sees a record. We need to make a copy of the listeners set before iterating them to avoid `set changed size during iteration` Fixes ``` 2024-04-12 16:31:25.699 ERROR (MainThread) [homeassistant] Error doing job: Exception in callback _SelectorDatagramTransport._read_ready() Traceback (most recent call last): File "/opt/homebrew/Cellar/python@3.12/3.12.2_1/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/events.py", line 88, in _run self._context.run(self._callback, *self._args) File "/opt/homebrew/Cellar/python@3.12/3.12.2_1/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/selector_events.py", line 1248, in _read_ready self._protocol.datagram_received(data, addr) File "src/zeroconf/_listener.py", line 86, in zeroconf._listener.AsyncListener.datagram_received File "src/zeroconf/_listener.py", line 104, in zeroconf._listener.AsyncListener.datagram_received File "src/zeroconf/_listener.py", line 175, in zeroconf._listener.AsyncListener._process_datagram_at_time File "src/zeroconf/_handlers/record_manager.py", line 161, in zeroconf._handlers.record_manager.RecordManager.async_updates_from_response File "src/zeroconf/_handlers/record_manager.py", line 70, in zeroconf._handlers.record_manager.RecordManager.async_updates_complete RuntimeError: set changed size during iteration ``` ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

test (3.8, ubuntu-latest, skip_cython)

Event loop is closed

test (3.8, ubuntu-latest, skip_cython)

Event loop is closed

test (3.8, ubuntu-latest, skip_cython)

Event loop is closed

test (3.8, ubuntu-latest, skip_cython)

Event loop is closed

test (3.12, ubuntu-latest, skip_cython)

Event loop is closed

test (3.12, ubuntu-latest, skip_cython)

Event loop is closed

test (3.12, ubuntu-latest, skip_cython)

Event loop is closed

test (3.12, ubuntu-latest, skip_cython)

Event loop is closed

test (3.12, ubuntu-latest, skip_cython)

Event loop is closed

test (3.11, ubuntu-latest, skip_cython)

Event loop is closed

test (3.11, ubuntu-latest, skip_cython)

Event loop is closed

test (3.11, ubuntu-latest, skip_cython)

Event loop is closed

test (3.11, ubuntu-latest, skip_cython)

Event loop is closed

test (3.10, ubuntu-latest, skip_cython)

Event loop is closed

test (3.10, ubuntu-latest, skip_cython)

Event loop is closed

test (3.10, ubuntu-latest, skip_cython)

Event loop is closed

test (3.10, ubuntu-latest, skip_cython)

Event loop is closed

test (3.9, ubuntu-latest, skip_cython)

Event loop is closed

test (3.9, ubuntu-latest, skip_cython)

Event loop is closed

test (3.9, ubuntu-latest, skip_cython)

Event loop is closed

test (3.9, ubuntu-latest, skip_cython)

Event loop is closed

test (3.9, macos-latest, skip_cython)

Event loop is closed

test (3.9, macos-latest, skip_cython)

Event loop is closed

test (3.9, macos-latest, skip_cython)

Event loop is closed

test (3.9, macos-latest, skip_cython)

Event loop is closed

test (3.9, macos-latest, skip_cython)

Process completed with exit code 1.

test (3.10, macos-latest, skip_cython)

Event loop is closed

test (3.10, macos-latest, skip_cython)

Event loop is closed

test (3.10, macos-latest, skip_cython)

Event loop is closed

test (3.10, macos-latest, skip_cython)

Event loop is closed

test (3.11, macos-latest, skip_cython)

Event loop is closed

test (3.11, macos-latest, skip_cython)

Event loop is closed

test (3.11, macos-latest, skip_cython)

Event loop is closed

test (3.11, macos-latest, skip_cython)

Event loop is closed

test (3.8, macos-latest, skip_cython)

Event loop is closed

test (3.8, macos-latest, skip_cython)

Event loop is closed

test (3.8, macos-latest, skip_cython)

Event loop is closed

test (3.8, macos-latest, skip_cython)

Event loop is closed

test (3.12, macos-latest, skip_cython)

Event loop is closed

test (3.12, macos-latest, skip_cython)

Event loop is closed

test (3.12, macos-latest, skip_cython)

Event loop is closed

test (3.12, macos-latest, skip_cython)

Event loop is closed

test (3.12, macos-latest, skip_cython)

Event loop is closed

test (3.12, windows-latest, skip_cython)

Event loop is closed

test (3.12, windows-latest, skip_cython)

Event loop is closed

test (3.12, windows-latest, skip_cython)

Event loop is closed

test (3.12, windows-latest, skip_cython)

Event loop is closed

test (3.10, windows-latest, skip_cython)

Event loop is closed

test (3.10, windows-latest, skip_cython)

Event loop is closed

test (3.10, windows-latest, skip_cython)

Event loop is closed

test (3.10, windows-latest, skip_cython)

Event loop is closed

test (3.11, windows-latest, skip_cython)

Event loop is closed

test (3.11, windows-latest, skip_cython)

Event loop is closed

test (3.11, windows-latest, skip_cython)

Event loop is closed

test (3.11, windows-latest, skip_cython)

Event loop is closed

test (3.8, windows-latest, skip_cython)

Event loop is closed

test (3.8, windows-latest, skip_cython)

Event loop is closed

test (3.8, windows-latest, skip_cython)

Event loop is closed

test (3.8, windows-latest, skip_cython)

Event loop is closed

test (3.8, windows-latest, skip_cython)

Event loop is closed

test (3.8, windows-latest, skip_cython)

Event loop is closed

test (3.11, ubuntu-latest, use_cython)

Event loop is closed

test (3.11, ubuntu-latest, use_cython)

Event loop is closed

test (3.11, ubuntu-latest, use_cython)

Event loop is closed

test (3.11, ubuntu-latest, use_cython)

Event loop is closed

test (3.12, ubuntu-latest, use_cython)

Event loop is closed

test (3.12, ubuntu-latest, use_cython)

Event loop is closed

test (3.12, ubuntu-latest, use_cython)

Event loop is closed

test (3.12, ubuntu-latest, use_cython)

Event loop is closed

test (3.12, ubuntu-latest, use_cython)

Event loop is closed

test (3.8, ubuntu-latest, use_cython)

Event loop is closed

test (3.8, ubuntu-latest, use_cython)

Event loop is closed

test (3.8, ubuntu-latest, use_cython)

Event loop is closed

test (3.8, ubuntu-latest, use_cython)

Event loop is closed

test (3.10, ubuntu-latest, use_cython)

Event loop is closed

test (3.10, ubuntu-latest, use_cython)

Event loop is closed

test (3.10, ubuntu-latest, use_cython)

Event loop is closed

test (3.10, ubuntu-latest, use_cython)

Event loop is closed

test (3.9, ubuntu-latest, use_cython)

Event loop is closed

test (3.9, ubuntu-latest, use_cython)

Event loop is closed

test (3.9, ubuntu-latest, use_cython)

Event loop is closed

test (3.9, ubuntu-latest, use_cython)

Event loop is closed

test (3.9, windows-latest, skip_cython)

Event loop is closed

test (3.9, windows-latest, skip_cython)

Event loop is closed

test (3.9, windows-latest, skip_cython)

Event loop is closed

test (3.9, windows-latest, skip_cython)

Event loop is closed

test (3.9, windows-latest, skip_cython)

Event loop is closed

Lint Commit Messages

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

lint

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v3, pre-commit/action@v2.0.3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

lint

The following actions uses node12 which is deprecated and will be forced to run on node16: pre-commit/action@v2.0.3. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

test (3.8, ubuntu-latest, skip_cython)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

test (3.12, ubuntu-latest, skip_cython)

test (3.11, ubuntu-latest, skip_cython)

test (3.10, ubuntu-latest, skip_cython)

test (3.9, ubuntu-latest, skip_cython)

test (3.9, macos-latest, skip_cython)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

test (3.10, macos-latest, skip_cython)