Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DNSOutgoing/DNSIncoming/DNSMessage into zeroconf._protocol #705

Merged
merged 1 commit into from Jun 17, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 17, 2021

  • This is an internal relocation, and does not affect the public API.

close #701 and closes #704

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #705 (2502ba7) into master (c368e1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          17       18    +1     
  Lines        2153     2161    +8     
  Branches      376      376           
=======================================
+ Hits         2116     2124    +8     
  Misses         23       23           
  Partials       14       14           
Impacted Files Coverage Δ
zeroconf/__init__.py 90.47% <100.00%> (+0.47%) ⬆️
zeroconf/_core.py 97.86% <100.00%> (+<0.01%) ⬆️
zeroconf/_dns.py 100.00% <100.00%> (ø)
zeroconf/_handlers.py 100.00% <100.00%> (ø)
zeroconf/_protocol.py 100.00% <100.00%> (ø)
zeroconf/_services/__init__.py 96.82% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c368e1c...2502ba7. Read the comment docs.

@bdraco bdraco merged commit f39bde0 into python-zeroconf:master Jun 17, 2021
@bdraco bdraco deleted the dnsoutgoing_split branch June 17, 2021 19:11
@bdraco
Copy link
Member Author

bdraco commented Jun 17, 2021

pylint issue pylint-dev/pylint#3525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document DNSOutgoing Relocate dnsincoming and dnsoutgoing ?
2 participants