Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build against pre-releases then stable releases. #472

Closed
wants to merge 1 commit into from
Closed

Build against pre-releases then stable releases. #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -13,7 +13,13 @@ jobs:

strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11-dev"]
python-version:
# Build on pre-releases until stable, then stable releases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment could be clearer.
IIUC this syntax is a workaround that will pick the latest available version (which is what we want), and the version could be an alpha, a beta, or a final/stable release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this comment verbatim from jaraco/skeleton. I agree, the comment could provide a whole narrative about why it exists, but I try to be concise, to describe as briefly as possible the reason for the syntax, and then link to an issue that provides more context and tracks ultimate resolution.

If you'd like to suggest different wording, I'd be willing to apply that here and in jaraco/skeleton.

# actions/setup-python#213
Comment on lines +17 to +18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this? I also expanded the link to make it easier to open.

Suggested change
# Build on pre-releases until stable, then stable releases.
# actions/setup-python#213
# This syntax will select the latest available releases
# including alpha, then beta, and finally stable releases.
# See https://github.com/actions/setup-python/issues/213

- ~3.8.0-0
- ~3.9.0-0
- ~3.10.0-0
- ~3.11.0-0

steps:
- uses: actions/checkout@v3
Expand Down