Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-115976: Add WASI to CI #116516

Merged
merged 10 commits into from Mar 11, 2024
Merged

GH-115976: Add WASI to CI #116516

merged 10 commits into from Mar 11, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 8, 2024

@brettcannon brettcannon self-assigned this Mar 8, 2024
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take a look that tests pass but produce this warning:

 z stack-size=524288 -Wl,--stack-first -Wl,--initial-memory=10485760   Modules/_testexternalinspection.o   -o Modules/_testexternalinspection.cpython-313d-wasm32-wasi.so
/bin/sh: 1: z: not found
make: [Makefile:3362: Modules/_testexternalinspection.cpython-313d-wasm32-wasi.so] Error 127 (ignored)
Error:  _testexternalinspection (/home/runner/work/cpython/cpython/cross-build/wasm32-wasi/build/lib.wasi-wasm32-3.13-pydebug/_testexternalinspection.cpython-313d-wasm32-wasi.so) is missing

@hugovk
Copy link
Member

hugovk commented Mar 8, 2024

build_wasi looks a bit lonely at https://github.com/python/cpython/actions/runs/8208735060?pr=116516 :

image

I think it requires listing in the needs section:

needs:
- check_source # Transitive dependency, needed to access `run_tests` value
- check-docs
- check_generated_files
- build_macos
- build_macos_free_threading
- build_ubuntu
- build_ubuntu_free_threading
- build_ubuntu_ssltests
- build_windows
- build_windows_free_threading
- test_hypothesis
- build_asan
- cifuzz

And then in either allowed-failures (if allowed to fail when selected to run) or allowed-skips (if it must pass when selected to run):

allowed-failures: >-
build_ubuntu_ssltests,
cifuzz,
test_hypothesis,
allowed-skips: >-
${{
!fromJSON(needs.check_source.outputs.run-docs)
&& '
check-docs,
'
|| ''
}}
${{
needs.check_source.outputs.run_tests != 'true'
&& '
check_generated_files,
build_macos,
build_macos_free_threading,
build_ubuntu,
build_ubuntu_free_threading,
build_ubuntu_ssltests,
build_windows,
build_windows_free_threading,
build_asan,
'
|| ''
}}
${{
!fromJSON(needs.check_source.outputs.run_cifuzz)
&& '
cifuzz,
'
|| ''
}}
${{
!fromJSON(needs.check_source.outputs.run_hypothesis)
&& '
test_hypothesis,
'
|| ''
}}

@brettcannon
Copy link
Member Author

Please, take a look that tests pass but produce this warning:

 z stack-size=524288 -Wl,--stack-first -Wl,--initial-memory=10485760   Modules/_testexternalinspection.o   -o Modules/_testexternalinspection.cpython-313d-wasm32-wasi.so
/bin/sh: 1: z: not found
make: [Makefile:3362: Modules/_testexternalinspection.cpython-313d-wasm32-wasi.so] Error 127 (ignored)
Error:  _testexternalinspection (/home/runner/work/cpython/cpython/cross-build/wasm32-wasi/build/lib.wasi-wasm32-3.13-pydebug/_testexternalinspection.cpython-313d-wasm32-wasi.so) is missing

#116229

@brettcannon
Copy link
Member Author

build_wasi looks a bit lonely

Fixed!

.github/workflows/build.yml Outdated Show resolved Hide resolved
brettcannon and others added 2 commits March 11, 2024 10:49
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@brettcannon brettcannon merged commit 05070f4 into python:main Mar 11, 2024
33 checks passed
@brettcannon brettcannon deleted the wasi-CI branch March 11, 2024 18:59
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants