Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-115983: skip building shared modules for testing under WASI #116528

Merged
merged 5 commits into from Mar 13, 2024
Merged

GH-115983: skip building shared modules for testing under WASI #116528

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4564db9
GH-115983: skip building shared modules for testing under WASI
brettcannon Mar 9, 2024
3374fe1
Add a news file
brettcannon Mar 9, 2024
281cb81
Move modules to exclude to `PY_STDLIB_MOD_SET_NA`
brettcannon Mar 11, 2024
63ce25a
Merge branch 'main' into skip-shared-test-modules-on-wasi
brettcannon Mar 11, 2024
c4f0582
Merge branch 'main' into skip-shared-test-modules-on-wasi
brettcannon Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2024-03-08-17-05-15.gh-issue-115983.ZQqk0Q.rst
View file
Open in desktop
@@ -0,0 +1 @@
Skip building test modules that must be built as shared under WASI.
6 changes: 6 additions & 0 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions configure.ac
View file
Open in desktop
Expand Up @@ -7398,11 +7398,19 @@ AS_CASE([$ac_sys_system],
[Emscripten/node*], [],
[WASI/*], [
dnl WASI SDK 15.0 does not support file locking, mmap, and more.
dnl Test modules that must be compiled as shared libraries are not supported
dnl (see Modules/Setup.stdlib.in).
PY_STDLIB_MOD_SET_NA(
[_ctypes_test],
[_testexternalinspection],
[_testimportmultiple],
[_testmultiphase],
[_testsinglephase],
erlend-aasland marked this conversation as resolved.
Show resolved Hide resolved
[fcntl],
[mmap],
[termios],
[xxlimited],
[xxlimited_35],
)
]
)
Expand Down