Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager #118881

Merged
merged 4 commits into from
May 20, 2024

Conversation

Sachaa-Thanasius
Copy link
Contributor

@Sachaa-Thanasius Sachaa-Thanasius commented May 10, 2024

The function name has an underscore. Without this, calling help can cause an exception.

Should be reproducible by calling help() in the repl on Windows. I personally found it by calling it on sysconfig.get_config_var.

Doesn’t seem worthy of a news entry.

The name with no underscore doesn't exist.
Copy link

cpython-cla-bot bot commented May 10, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4 Eclips4 changed the title Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager gh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager May 19, 2024
@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label May 19, 2024
@Eclips4 Eclips4 requested a review from pablogsal May 19, 2024 20:51
@JelleZijlstra JelleZijlstra merged commit 05e1dce into python:main May 20, 2024
38 of 39 checks passed
@miss-islington-app
Copy link

Thanks @Sachaa-Thanasius for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
…be `tempfile_pager` (pythonGH-118881)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)

Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

GH-119211 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
@Sachaa-Thanasius Sachaa-Thanasius deleted the patch-1 branch May 20, 2024 14:54
@Sachaa-Thanasius Sachaa-Thanasius restored the patch-1 branch May 20, 2024 14:55
@Sachaa-Thanasius Sachaa-Thanasius deleted the patch-1 branch May 20, 2024 14:55
JelleZijlstra pushed a commit that referenced this pull request May 20, 2024
… be `tempfile_pager` (GH-118881) (#119211)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)

Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@ambv ambv added the topic-repl Related to the interactive shell label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants