Infer top-level names for a package #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harupy
reviewed
Aug 26, 2021
| def _top_level_inferred(dist): | ||
| return { | ||
| f.parts[0] if len(f.parts) > 1 else f.with_suffix('').name | ||
| for f in dist.files |
There was a problem hiding this comment.
Hi @jaraco, does this line throw when dist.files returns None? In our repo, we observed an issue that seems related to this line:
https://github.com/mlflow/mlflow/runs/3428616955#step:5:7078
File "/miniconda/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 1016, in packages_distributions
for pkg in _top_level_declared(dist) or _top_level_inferred(dist):
File "/miniconda/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 1026, in _top_level_inferred
return {
TypeError: 'NoneType' object is not iterable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #330.