fix PathDistribution._normalized_name implementation
#377
Conversation
|
Thanks @benoit-pierre for this proposal. Unfortunately, I'm struggling a little bit with it, mainly because it fixes two unreported bugs in one commit. I'm also uneasy about the added complexity that "normalized names" is adding here (requiring fixtures with multiple return values). Would you mind writing up a bug report describing how you encountered this bug and how we might replicate it (and prove the fix)? I'm a little disappointed in the test suite right now. It seems the performance tests aren't running. Also, the linter didn't catch that |
|
In #379, I've addressed the first issue. |
jaraco
force-pushed
the
fix_PathDistribution._normalized_name_implementation
branch
3 times, most recently
from
ad58bb0
to
1a1a3db
Compare
- apply PEP 503 normalization to the extracted names (e.g.: `zope..inter_face-4.2.dist-info` must yield the name `zope_inter_face`) `entry_points(…)` can yield the entry-points of a shadowed distribution. For example: with a version of `mypkg` in the system' site-packages directory when working from another development checkout of the same package (with a `mypkg.egg-info` directory mishandled by the first bug).
jaraco
force-pushed
the
fix_PathDistribution._normalized_name_implementation
branch
from
1a1a3db
to
596abd0
Compare
| assert version(pkg_name) == '1.0' | ||
| pkg_name, norm_pkg_name = self.pkg_with_dashes(self.site_dir) | ||
| dist = distribution(pkg_name) | ||
| assert dist._normalized_name == norm_pkg_name |
There was a problem hiding this comment.
Instead of testing the internal implementation details, I'd rather have a test that captures the failed expectation - namely that entry points of two packages whose file system names vary only by normalization won't deduplicate.
|
In #381, I've found I can capture the missed expectation by simply tweaking the test for |
pkg.egg-infomust yield the namepkg, notpkg.egg)zope..inter_face-4.2.dist-infomust yield the namezope_inter_face)Both are necessary, or
entry_points(…)can yield the entry-points of a shadowed distribution. For example: with a version ofmypkgin the system' site-packages directory when working from another development checkout of the same package (with amypgk.egg-infodirectory mishandled by the first bug).