Fix type annotation in SimplePath.__truediv__
#469
Conversation
|
shouldn't |
| @@ -52,7 +52,7 @@ class SimplePath(Protocol[_T]): | |||
| def joinpath(self, other: Union[str, _T]) -> _T: | |||
| ... # pragma: no cover | |||
|
|
|||
| def __truediv__(self, other: Union[str, _T]) -> _T: | |||
| def __truediv__(self, other: _T) -> _T: | |||
There was a problem hiding this comment.
I'm not sure this annotation is correct. A SimplePath could accept a str as input and return a SimplePath. I understand that pathlib.Path is parameterized (the subtype is either str or bytes), but maybe SimplePath should just assume str. The only thing I'm uncertain about is if existing uses might utilize a Path[bytes]. That is, maybe we should eliminate T and replace it with SimplePath... so __truediv__ accepts other: Union[str, 'SimplePath'].
|
FWIW, I think I might have misspoken in python/typeshed#10665 (comment) -- this annotation doesn't look as bad as I thought when I gave my analysis there (which is what prompted Nikita to create this PR). |
|
Based on the discussion, my understanding is that the status quo is probably acceptable and thus we'll choose to reject this change (and its unresolved concerns). Thanks anyhow for the proposal. If you wish to revisit the concern, let's be sure to answer the open concerns about correctness and consistency. |
Closes #468