(馃巵) canwecolor馃殌 #14051
Merged
(馃巵) canwecolor馃殌 #14051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
canwecolor
branch
from
59d85c4
to
7d5aa6f
Compare
This comment has been minimized.
This comment has been minimized.
|
@ilevkivskyi Do you think this is a good one? |
ilevkivskyi
approved these changes
Dec 6, 2022
pytest.ini
Outdated
| @@ -21,7 +21,7 @@ python_functions = | |||
| # always run in parallel (requires pytest-xdist, see test-requirements.txt) | |||
| # and enable strict mode: require all markers | |||
| # to be defined and raise on invalid config values | |||
| addopts = -nauto --strict-markers --strict-config | |||
| addopts = -nauto --strict-markers --strict-config --color=yes | |||
There was a problem hiding this comment.
Would it be possible to instead add this flag in workflow config? Changing this file will affect local testing as well.
There was a problem hiding this comment.
Okay, I've added PYTEST_ADDOPTS to the workflow file and verified that it cooperates with the addopts config in pytest.ini.
There was a problem hiding this comment.
ergh, that isn't working.....
Edit: Had to update tox passenv
KotlinIsland
force-pushed
the
canwecolor
branch
from
7d5aa6f
to
29372c1
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
canwecolor
branch
from
29372c1
to
4c7f125
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
canwecolor
branch
from
4c7f125
to
96f175b
Compare
This comment has been minimized.
This comment has been minimized.
KotlinIsland
force-pushed
the
canwecolor
branch
from
96f175b
to
d7ccbc3
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 馃馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time i checked it wasn't the 1960's. So I think the CI could be colorized.
Configured pytest, tox, mypy(#7771) and pip鹿 (I already already colorized black and isort when I initially added them)
1: Pip doesn't work yet pypa/pip#10909, so this is just a placedholder for when it (hopefully) soon will.