[PEP 695] Implement new scoping rules for type parameters #17258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy/semanal.py
Outdated
| SCOPE_CLASS: Final = 1 # Class body | ||
| SCOPE_FUNC: Final = 2 # Function or lambda | ||
| SCOPE_COMPREHENSION: Final = 3 # Comprehension or generator expression | ||
| SCOPE_TYPE_PARAM: Final = 4 # Python 3.12 new-style type parameter scope (PEP 695) |
There was a problem hiding this comment.
The same scoping is used for type alias values and in the future will be used for annotations (under PEP 649). In CPython we're calling this "annotation scopes", I'd suggest using the same here:
Suggested change
| SCOPE_TYPE_PARAM: Final = 4 # Python 3.12 new-style type parameter scope (PEP 695) | |
| SCOPE_ANNOTATION: Final = 4 # Annotation scopes for type parameters and aliases (PEP 695) |
There was a problem hiding this comment.
Renamed as suggested.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JelleZijlstra
approved these changes
May 17, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type parameters get a separate scope with some special features.
Work on #15238.