Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stubsabot] Bump hvac to 2.2.* #11839

Merged
merged 4 commits into from May 21, 2024
Merged

[stubsabot] Bump hvac to 2.2.* #11839

merged 4 commits into from May 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Release: https://pypi.org/pypi/hvac/2.2.0
Homepage: https://github.com/hvac/hvac
Repository: https://github.com/hvac/hvac
Typeshed stubs: https://github.com/python/typeshed/tree/main/stubs/hvac
Diff: hvac/hvac@v2.1.0...v2.2.0

Stubsabot analysis of the diff between the two releases:

  • 1 public Python file has been added: hvac/api/secrets_engines/ldap.py.
  • 0 files included in typeshed's stubs have been deleted.
  • 8 files included in typeshed's stubs have been modified or renamed.
  • Total lines of Python code added: 818.
  • Total lines of Python code deleted: 29.

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI

Release: https://pypi.org/pypi/hvac/2.2.0
Homepage: https://github.com/hvac/hvac
Repository: https://github.com/hvac/hvac
Typeshed stubs: https://github.com/python/typeshed/tree/main/stubs/hvac
Diff: hvac/hvac@v2.1.0...v2.2.0

Stubsabot analysis of the diff between the two releases:
 - 1 public Python file has been added: `hvac/api/secrets_engines/ldap.py`.
 - 0 files included in typeshed's stubs have been deleted.
 - 8 files included in typeshed's stubs have been modified or renamed.
 - Total lines of Python code added: 818.
 - Total lines of Python code deleted: 29.

If stubtest fails for this PR:
- Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
- Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI
@github-actions github-actions bot added the bot: stubsabot 🤖 PRs created by stubsabot 🤖 label Apr 28, 2024
@AlexWaygood AlexWaygood reopened this Apr 28, 2024
@JelleZijlstra
Copy link
Member

This library has types in many of its docstrings; I added a few I noticed while dealing with stubtest issues.

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit: hvac.api.secret_engines.identity removes DEFAULT_MOUNT_POINT and instead imports it from hvac.constants.identity. We could either remove it from the former or re-export it.

Copy link
Contributor Author

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 489e8db into main May 21, 2024
48 checks passed
@srittau srittau deleted the stubsabot/hvac branch May 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: stubsabot 🤖 PRs created by stubsabot 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants