New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Image type for docker container run image parameter #11900

Merged

srittau merged 1 commit into python:main from adamtheturtle:allow-image-docker-container-run

May 12, 2024

Contributor

adamtheturtle commented May 11, 2024 •

edited

The docstring says that this must be a string, but the implementation explicitly allows an Image:

https://github.com/docker/docker-py/blob/b6464dbed92b14b2c61d5ee49805fce041a3e083/docker/models/containers.py#L850-L851

if isinstance(image, Image):
    image = image.id


          Allow Image type for docker container run image parameter

b8d448c

The docstring says that this must be a string, but the implementation
explicitly allows an Image:

https://github.com/docker/docker-py/blob/b6464dbed92b14b2c61d5ee49805fce041a3e083/docker/models/containers.py#L850-L851

```python
if isinstance(image, Image):
            image = image.id
```

Contributor

github-actions bot commented May 11, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau approved these changes

View reviewed changes

srittau merged commit f75211b into python:main

42 checks passed

adamtheturtle deleted the allow-image-docker-container-run branch

May 12, 2024 10:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment