Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Readme to include instructions for Low Disk Storage problem #345

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShatilKhan
Copy link

Description

I've added a link to this hackmd post in the docker readme on how to setup the environment in case of low storage on C Drive

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other (Documentation Update)

cc: @vfdev-5

Copy link

netlify bot commented Dec 25, 2023

👷 Deploy request for code-generator pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e296cae

docker/readme.md Outdated Show resolved Hide resolved
@vfdev-5
Copy link
Member

vfdev-5 commented Dec 25, 2023

@ShatilKhan I think it would be better to incorporate the text from hackmd into this README directly.

@ShatilKhan
Copy link
Author

I was actually thinking the same thing
Then I'll add the hackmd text on my next commit

@vfdev-5
Copy link
Member

vfdev-5 commented Jan 15, 2024

@ShatilKhan any updates on this PR?

@ShatilKhan
Copy link
Author

@ShatilKhan any updates on this PR?

Yes I'm working on it, I'll update it soon

Copy link
Author

@ShatilKhan ShatilKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated readme to include full instructions

@vfdev-5
Copy link
Member

vfdev-5 commented Jan 23, 2024

@ShatilKhan thanks for the update, but the content starting from horizontal line and the text "After setting up Docker and whatever the issue with space and docker is:" does not look neat and more like a dump various notes.
Can you restructure such that it keeps existing logic of headers levels and the content logic, also fix the indents in the vscode config?

Here is how it looks like now: https://github.com/pytorch-ignite/code-generator/blob/e296caeb8f6150870f17984de0f4b0cce5194118/docker/readme.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants