New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UFMT format on test/test_utils.py #125996
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125996
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 899133c with merge base 1115a25 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
test/test_utils.py
Outdated
p = subprocess.Popen(command, stdout=subprocess.PIPE, # noqa: P204 | ||
stderr=subprocess.PIPE, shell=True) | ||
p = subprocess.Popen( | ||
command, | ||
stdout=subprocess.PIPE, # noqa: P204 | ||
stderr=subprocess.PIPE, | ||
shell=True, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the location of noqa
may be wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's unnecessary, let me try to remove it.
is clean |
@pytorchbot merge -i |
This PR needs to be approved by an authorized maintainer before merge. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes some files in pytorch#123062 Run lintrunner on files: test/test_utils.py ```bash $ lintrunner -a --take UFMT --all-files ok No lint issues. Successfully applied all patches. Pull Request resolved: pytorch#125996 Approved by: https://github.com/ezyang
Fixes some files in #123062
Run lintrunner on files:
test/test_utils.py