New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CUB submodule #125997
Remove CUB submodule #125997
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125997
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 5443d9a with merge base d61a81a (): NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
there's still some work to do, convert to a draft temporarily. |
This whole submodule isn't used anymore and can probably just be removed. (We use the version bundled with CUDA I believe). |
@Skylion007 Thanks for your guidance! I'm on it. :p |
4b8f86f
to
a9539a0
Compare
@Skylion007 @bhack I removed cub submodule, and pytorch was installed successfully from source by running |
We could kick-off the CI jobs suite. |
I've started the CI. |
You also need to remove the conditional in the cmake files that tries to load the CUB sub module if the system level on cannot be found. |
Do we still have this logic? |
a9539a0
to
5443d9a
Compare
fixed by #126540 |
Fixes #125981
The NVlabs/cub isn't used anymore, so it's removed in this pull request.