Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict default value in StateDictOptions #125998

Closed
wants to merge 3 commits into from

Conversation

shink
Copy link
Contributor

@shink shink commented May 11, 2024

Copy link

pytorch-bot bot commented May 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125998

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 07a3930 with merge base 1c3fe84 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue labels May 11, 2024
@shink shink changed the title Fix strict default value in Fix strict default value in StateDictOptions May 11, 2024
@ad8e
Copy link
Contributor

ad8e commented May 12, 2024

If the default value should be True, the doc line might as well be removed, since the function interface already says it's True.

@shink
Copy link
Contributor Author

shink commented May 13, 2024

@ad8e Thanks for your review. The doc line has been removed as you said.

Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@fegin
Copy link
Contributor

fegin commented May 16, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 16, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@fegin fegin added the topic: docs topic category label May 16, 2024
@fegin
Copy link
Contributor

fegin commented May 16, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@fegin fegin added the topic: not user facing topic category label May 16, 2024
@fegin
Copy link
Contributor

fegin commented May 16, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
Fixes pytorch#125992

The default value of the parameter `strict` should be `True`.

Pull Request resolved: pytorch#125998
Approved by: https://github.com/fegin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: docs topic category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateDictOptions claims default strict is False, but it's actually True
5 participants