Add Stanford Sentiment Treebank (SST) dataset #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 77.93% 78.06% +0.13%
==========================================
Files 65 66 +1
Lines 3585 3616 +31
==========================================
+ Hits 2794 2823 +29
- Misses 791 793 +2
Continue to review full report at Codecov.
|
cpuhrsch
reviewed
Feb 19, 2021
torchtext/datasets/sst.py
Outdated
| try: | ||
| from nltk.tree import Tree | ||
| except ImportError: | ||
| print("Please install NLTK. See the docs at https://nltk.org for more information.") |
There was a problem hiding this comment.
I'd raise this as an error, so that processing doesn't continue. And further I'd make explicit that this is due to this dataset specifically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy SST was retired in
torchtext.legacyfolder. This one yields the raw text strings.