Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuda 11.8 & 12 builds and Python 3.11 #2076

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

johnnynunez
Copy link

Changes:
Python base test: 3.10 (Release in march by Anaconda)
Future Python 3.11 support
Cuda 11.8 builds
Cuda 12.0 builds

@joecummings
Copy link
Contributor

cc @atalman @osalpekar

@osalpekar
Copy link
Member

Looks like these are adding 3.11 support for the unittest jobs, but the jobs are failing due to version conflicts since some dependencies are not available for 3.11 in conda. We should perhaps wait for this until the deps are available and unittest jobs are able to run green reliably so the red signal doesn't affect torchtext dev's workflow - @joecummings lmk what you think about this.

@johnnynunez
Copy link
Author

Looks like these are adding 3.11 support for the unittest jobs, but the jobs are failing due to version conflicts since some dependencies are not available for 3.11 in conda. We should perhaps wait for this until the deps are available and unittest jobs are able to run green reliably so the red signal doesn't affect torchtext dev's workflow - @joecummings lmk what you think about this.

it's similar problem with torchvision, but in theory anaconda will release the python binaries already in mid-March. So, I already prepare test...

@joecummings
Copy link
Contributor

Looks like these are adding 3.11 support for the unittest jobs, but the jobs are failing due to version conflicts since some dependencies are not available for 3.11 in conda. We should perhaps wait for this until the deps are available and unittest jobs are able to run green reliably so the red signal doesn't affect torchtext dev's workflow - @joecummings lmk what you think about this.

it's similar problem with torchvision, but in theory anaconda will release the python binaries already in mid-March. So, I already prepare test...

Got it. Thanks for the addition! I agree w/ @osalpekar that we'll wait until mid-March to merge, but I appreciate you being so on top of things here.

@johnnynunez johnnynunez marked this pull request as ready for review March 16, 2023 02:27
@johnnynunez
Copy link
Author

Looks like these are adding 3.11 support for the unittest jobs, but the jobs are failing due to version conflicts since some dependencies are not available for 3.11 in conda. We should perhaps wait for this until the deps are available and unittest jobs are able to run green reliably so the red signal doesn't affect torchtext dev's workflow - @joecummings lmk what you think about this.

it's similar problem with torchvision, but in theory anaconda will release the python binaries already in mid-March. So, I already prepare test...

Got it. Thanks for the addition! I agree w/ @osalpekar that we'll wait until mid-March to merge, but I appreciate you being so on top of things here.

conda 3.11 binaries are avaible

@johnnynunez
Copy link
Author

Python 3.11 support added via conda/conda#12256, this will be included in the May release of conda 23.5.0

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 25, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2076

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants