Fix: dont use importlib_metadata v5.0 due to deprecated behavior and interface. #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface. Summary: Temporarily peg importlib_metadata to <5.0 due do breaking changes (python/importlib_metadata#409) for CPython 3.7 The right fix is to use `metadata.entry_points(group=group, name=name)`, however typechecker does not recognize the changes (python/importlib_metadata@7e5bae4) Differential Revision: D40053701 fbshipit-source-id: 2cc6adab47945334104c150af005057845839b73
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40053701 |
|
Apologies for the breakage here. Please let me know if I can help devise a more permanent fix. |
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 94.74% 94.81% +0.07%
==========================================
Files 63 63
Lines 4169 4169
==========================================
+ Hits 3950 3953 +3
+ Misses 219 216 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Temporarily peg importlib_metadata to <5.0 due do breaking changes (python/importlib_metadata#409) for CPython 3.7
The right fix is to use
metadata.entry_points(group=group, name=name), however typechecker does not recognize the changes (python/importlib_metadata@7e5bae4)Differential Revision: D40053701