New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc building in CI #6884
Fix doc building in CI #6884
Conversation
Thanks for the PR @pmeier . The related VideoReader issue seems a bit fishy #6875 (comment), I think we should figure out whether there's something wrong with it before committing to removing |
@@ -33,6 +33,7 @@ clean: | |||
rm -rf $(SOURCEDIR)/auto_examples/ # sphinx-gallery | |||
rm -rf $(SOURCEDIR)/gen_modules/ # sphinx-gallery | |||
rm -rf $(SOURCEDIR)/generated/ # autosummary | |||
rm -rf $(SOURCEDIR)/models/generated # autosummary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was missing
from typing import Any, Dict, Iterator | ||
|
||
import torch | ||
|
||
from ..utils import _log_api_usage_once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are no longer needed. flake8
didn't pick up on this since we blanket ignore F401
, i.e. unused imports, in __init__.py
files:
Lines 14 to 15 in c4c0ef9
per-file-ignores = | |
__init__.py: F401, F403, F405 |
@@ -43,8 +37,6 @@ | |||
"_read_video_timestamps_from_memory", | |||
"_probe_video_from_memory", | |||
"_HAS_VIDEO_OPT", | |||
"_read_video_clip_from_memory", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are no longer available.
Although the build hangs in the I'll investigate further what exactly is causing the issue. |
Narrowed it down to vision/gallery/plot_video_api.py Lines 98 to 107 in 1921613
Behavior can be reproduced by replacing this with video.set_current_stream("video")
for _ in video.seek(2):
pass and commenting out the rest of file. @jdsgomes @bjuncek any idea what your PR changed that could interfere with sphinx multiprocessing? |
I've pushed the reproduction to this PR. To reproduce locally, check this PR out and do cd docs
pip install -r requirements.txt
make clean
make html You probably also want to apply sphinx-doc/sphinx#10952 locally so using |
build_docs is green now, will trigger rebuild to see it it is flaky |
It is still red on main: https://app.circleci.com/pipelines/github/pytorch/vision/21716/workflows/d4a070b9-cdb0-4929-a518-56e8b43fbe20/jobs/1759489. I'll try to reproduce again locally, but I could do so without issues yesterday. |
It seems I reduced it down to much. Trying to reproduce it again with the reduced version today did no longer work. No idea why it worked yesterday. Sorry for that. However, reverting the file back to its full content surfaces the error again. I pushed the change to this PR. Docs CI is red the same as on |
Fixes #6875.