New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorize font path computation #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Thanks. Let me take a look at the test failures and see if I can come up with a quick fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I merged @mraspaud's PR into main and tried merging it into your branch. I think I made all the necessary fixes for the conflicts...oops pre-commit is failing. I guess not. |
@avalentino Do you need a release with these recent changes (pillow 9.4 and font path) to make your life easier? |
If I understand correctly the actual code was already OK, only the test code have been changes since the last release. |
This PR does not fix any issue and do not provide any new feature.
It simply factorize the computation of the
DejaVuSerif.ttf
font path in a single point and uses the computed variable where needed.It is a purely aesthetic change, but it makes life a little bit easier to packager that need to patch the font path.
Please note that test failures are unrelated to this change.
They are due to an incompatibility with Pillow v9.4 described in #82.
git diff origin/main **/*py | flake8 --diff