continue on error for the greeter #3407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoyama010
approved these changes
Oct 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #3407 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 84 84
Lines 18509 18509
=======================================
Hits 17572 17572
Misses 937 937 |
|
Continue on error still means these fail. I'm going to simply comment this out until this is fixed. |
|
Simply disabled via disabling-a-workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm implementing the suggestion from this discussion point to simply continue on error until this has been fixed upstream.