WIP: macOS implementation of keyboard, mouse, AxElementInfo and Application #841
+2,178
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Keyboard module + unit tests 2.Mouse module + unit tests. Also travis yml file updated to support OS tests.
…tended to bundleID
…ed unitest for ax_element_info
…mac_os_application
# Conflicts: # pywinauto/application.py # pywinauto/unittests/test_keyboard.py
Replaced dev packages from setup.py to dev-req file Grouped dev packages by platfrom
Added macos application as dmg images. Updated ci configuration for mac os .
Updated following points: 1. Starting application logic 2. Unit tests for application.
MacOS tests updates
Created some new tests.
…fixes Extracted common init+deinit logic to setup and teardown.
airelil
reviewed
Apr 25, 2020
|
|
||
| pass | ||
|
|
||
| class ApplicationEspecialTestCases(unittest.TestCase): |
There was a problem hiding this comment.
A small suggestion, so if these tests for start/end, let's than call it ApplicationStartEndTestCases.
| """ | ||
| Unit tests for the application.Application class | ||
| There are test cases which has unique start/end logic | ||
| """ |
There was a problem hiding this comment.
Even for these special cases it'd be better to have a proper cleanup. Remember that if test fails we don't want any leftovers.
def setUp(self):
self.app = Application()
def tearDown(self):
self.app.kill()
Closed
|
Any update on this? I see there is a related issue that was created after this PR was opened: #1137 The branch currently says:
Is it worth continuing from here or starting fresh? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial implementation of the most basic classes for macOS backend "ax".
Any comments and suggestions are highly appreciated.
Big TODOs:
.dmgpackages).AxWrapperand derived classes (even not started yet).Thanks:
mouseandkeyboardmodules.AxElementInfoandApplicationclasses.