Fix #4420: Update home key and end key navigation in Calendar component #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 2, 2024 11:49
Adjust home and end handlers to align with W3C WAI-ARIA principles. Previously navigation moves to the first and last day of the week instead of one year before and after the calendar. After this change, it's moving to [the first and last day of the week](https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/) Closes Hacker0x01#4420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Hacker0x01#4420
Description
This PR addresses the navigation behavior in the calendar component to enhance accessibility based on W3C WAI-ARIA principles. Previously, the home and end key handers navigated one year before and after the selected (which is the handlers for shift+PageUp and shift+PageDown), which could be confusing for users. The update modifies the behavior to move to the first and last day of the week, providing a more intuitive and accessible experience.
Reference Link
Changes Made
Related issues
Closes Hacker0x01#4420
I'll create a separate PR to fix the shift+pageUp and shift+pageDown issue, currently, it's working like PageUp and PageDown