Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to configure the amount of times the healthcheck fails #2272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdloh
Copy link

@cdloh cdloh commented May 9, 2024

Adds the ability to configure the amount of times that the healthcheck can fail before the system will restart the VPN

Context

My internet gets a bit flaky when it's maxed out attempting to put traffic through the VPN. There's nothing actually wrong with the connection and traffic is flowing fine but the healthcheck times out or refuses to connect every so often.

This then causes the VPN to flap and restart and then connect again and get stuck in a loop.

This change allows the healthcheck to attempt a few more times. I've been running this for a while and it solves my issue and keeps the connection healthy.

If you're happy with this feature I'm happy to clean it up a bit more and update the wiki as required.

Adds the ability to configure the amount of times that the healthcheck can fail
before the system will restart the VPN
@cdloh
Copy link
Author

cdloh commented May 12, 2024

Looks like you pushed some healthcheck changes in latest. I'll test to see if it largely solves my issues and discard this if it does 👍

@qdm12
Copy link
Owner

qdm12 commented May 16, 2024

Adds the ability to configure the amount of times that the healthcheck can fail before the system will restart the VPN

Why not just increase HEALTH_VPN_DURATION_INITIAL?

Looks like you pushed some healthcheck changes in latest. I'll test to see if it largely solves my issues and discard this if it does

Indeed, sorry maybe I missed your PR before. The change might help, it essentially increases the dialing timeout on every try (instead of fixed 3 seconds), and the health initial vpn duration was increased as well.

I don't think the number of attempts adds much value, although it could replace the existing timer (but retro-compatibility, so we're stuck until v4). Now feel free to discuss ideas etc. to improve it as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants