Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply committed Raft entries in a separate thread #4069

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Apr 18, 2024

This PR applies committed Raft entries in a separate thread (using RawNode::advance_append and RawNode::advance_apply_to). This should considerably speed up consensus thread...

Currently based on #3964, will be rebased on dev once it's merged.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ffuugoo
Copy link
Contributor Author

ffuugoo commented Apr 19, 2024

When using no-ops (finish non-existing shard transfer) as the simplest test, consensus is doing 10k ops / second. 🤯🤯🤯

@ffuugoo ffuugoo force-pushed the enable-raft-message-batching branch from 5917246 to 997566f Compare April 25, 2024 12:20
Base automatically changed from enable-raft-message-batching to dev May 13, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant