Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'comment' field to collection apis (#3957) #4107

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

abhishek818
Copy link
Contributor

helps in providing table metadata

fixes: #3957
/claim #3957

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@abhishek818 abhishek818 changed the title add 'properties' field to collection apis (#3957) WIP: add 'properties' field to collection apis (#3957) Apr 24, 2024
@abhishek818 abhishek818 marked this pull request as draft April 24, 2024 11:08
@@ -316,6 +317,7 @@ message UpdateCollection {
optional VectorsConfigDiff vectors_config = 6; // New vector parameters
optional QuantizationConfigDiff quantization_config = 7; // Quantization configuration of vector
optional SparseVectorConfig sparse_vectors_config = 8; // New sparse vector parameters
map<string, string> properties = 9; // New properties of the collection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have a single optional string called comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved.

@abhishek818 abhishek818 changed the title WIP: add 'properties' field to collection apis (#3957) add 'comment' field to collection apis (#3957) Apr 24, 2024
@abhishek818 abhishek818 marked this pull request as ready for review April 24, 2024 13:22
@generall
Copy link
Member

Hey @abhishek818, I believe the last step would be to trigger API schema gen https://github.com/qdrant/qdrant/blob/master/docs/DEVELOPMENT.md#rest

@timvisee
Copy link
Member

@generall Do you think a comment field would be sufficient? I'd expect an interface that is a bit more fully-fledged; something like the payload API but on collection level.

@generall
Copy link
Member

I'd expect an interface that is a bit more fully-fledged; something like the payload API but on collection level.

I would prefer to not over-complicate this. As I understood - the main use-case is o give more information about the collection than it would normally fit into the name.

If we would need payload-like data in the collection, we can make another change

Copy link
Member

@generall generall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires ability to update the comment. And it doesn't look the comment even persisted

@abhishek818 abhishek818 marked this pull request as draft May 29, 2024 10:53
@abhishek818 abhishek818 marked this pull request as ready for review May 29, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants