-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'comment' field to collection apis (#3957) #4107
base: dev
Are you sure you want to change the base?
Conversation
@@ -316,6 +317,7 @@ message UpdateCollection { | |||
optional VectorsConfigDiff vectors_config = 6; // New vector parameters | |||
optional QuantizationConfigDiff quantization_config = 7; // Quantization configuration of vector | |||
optional SparseVectorConfig sparse_vectors_config = 8; // New sparse vector parameters | |||
map<string, string> properties = 9; // New properties of the collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have a single optional string called comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved.
0c3f189
to
3d6a907
Compare
Hey @abhishek818, I believe the last step would be to trigger API schema gen https://github.com/qdrant/qdrant/blob/master/docs/DEVELOPMENT.md#rest |
@generall Do you think a comment field would be sufficient? I'd expect an interface that is a bit more fully-fledged; something like the payload API but on collection level. |
I would prefer to not over-complicate this. As I understood - the main use-case is o give more information about the collection than it would normally fit into the name. If we would need payload-like data in the collection, we can make another change |
helps in providing table metadata or properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR requires ability to update the comment. And it doesn't look the comment even persisted
helps in providing table metadata
fixes: #3957
/claim #3957
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: