-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
universal-query: Add query()
to ShardOperation
trait
#4210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coszio
force-pushed
the
new-grpc-vector-message
branch
from
May 13, 2024 13:32
8de9f77
to
a0ddb6e
Compare
coszio
force-pushed
the
universal-query-at-shard-ops
branch
from
May 13, 2024 13:41
6265e17
to
2368ae5
Compare
coszio
force-pushed
the
new-grpc-vector-message
branch
from
May 13, 2024 21:25
a0ddb6e
to
9afc305
Compare
coszio
force-pushed
the
universal-query-at-shard-ops
branch
from
May 14, 2024 15:43
2368ae5
to
9680232
Compare
agourlay
approved these changes
May 15, 2024
timvisee
approved these changes
May 15, 2024
.into_iter() | ||
.chunks(value.dim) | ||
.into_iter() | ||
.map(Iterator::collect::<Vec<_>>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fun one, haven't seen it like this before 😄
coszio
force-pushed
the
universal-query-at-shard-ops
branch
from
May 15, 2024 13:16
54374eb
to
70e8a47
Compare
generall
pushed a commit
that referenced
this pull request
May 26, 2024
* add `query` to shard trait * add missing conversions for query * update grpc docs * Query response has intermediate results * add ShardQueryResponse description * move pub use to the top, keep only one way of reaching reexports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #4209
Still some partial implementation for shard handling of query requests:
query()
required method on theShardOperation
trait, which receives theShardQueryRequest
type.ShardQueryRequest
to the grpcQueryShardPoints
typesitertools
to the workspace dependenciesAll Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?