Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSON-RPC plugin uploads #266

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

komima
Copy link
Contributor

@komima komima commented Nov 8, 2022

Fix for issue #265

@komima
Copy link
Contributor Author

komima commented Nov 8, 2022

It seems the devweb container failed to start in the test workflow, I'll investigate more with local containers.

@komima
Copy link
Contributor Author

komima commented Nov 8, 2022

celery/celery#7783 (comment)

New version of importlib_metadata was causing the worker to fail on start, and devweb depending on it failing to start (hanging) as well, it seems pinning the version in the docker REQUIREMENTS.txt works.

@dimasciput
Copy link
Collaborator

@komima Thanks for fixing the testing workflow!

The changes looks good, let me merge and deploy it tomorrow.

@codecov-commenter
Copy link

Codecov Report

Base: 37.72% // Head: 74.15% // Increases project coverage by +36.43% 🎉

Coverage data is based on head (c5cec6d) compared to base (907eaaf).
Patch coverage: 69.11% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #266       +/-   ##
===========================================
+ Coverage   37.72%   74.15%   +36.43%     
===========================================
  Files          88      123       +35     
  Lines        3714     4689      +975     
===========================================
+ Hits         1401     3477     +2076     
+ Misses       2313     1212     -1101     
Impacted Files Coverage Δ
qgis-app/base/license.py 91.66% <0.00%> (+66.66%) ⬆️
...rations/0003_rename_Review_model_and_file_field.py 100.00% <ø> (ø)
qgis-app/plugins/templatetags/range_filter.py 50.00% <0.00%> (ø)
qgis-app/plugins/tests/__init__.py 100.00% <ø> (ø)
...-app/styles/migrations/0003_stylereview_comment.py 100.00% <ø> (ø)
...s-app/styles/migrations/0004_auto_20201108_0742.py 100.00% <ø> (ø)
...-app/styles/migrations/0005_style_modified_date.py 100.00% <ø> (ø)
...yles/migrations/0006_stylereview_require_action.py 100.00% <ø> (ø)
...s-app/styles/migrations/0007_auto_20201109_0112.py 100.00% <ø> (ø)
qgis-app/styles/templatetags/styles_custom_tags.py 21.05% <0.00%> (ø)
... and 173 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dimasciput dimasciput merged commit 8d70d06 into qgis:master Nov 9, 2022
@dimasciput
Copy link
Collaborator

hi @komima, this has been deployed to plugins.qgis.org

@komima
Copy link
Contributor Author

komima commented Nov 18, 2022

@dimasciput the update worked great last week for plugin upload in our CI pipeline, but now it seems the deployment has been rolled back to a previous version without this fix, do you know why that might happen?

@dimasciput
Copy link
Collaborator

@komima can you give it another try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants