Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[attribute form] Add parent feature scope when adding/editing a child featur through the relation editor widget #57271

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Apr 29, 2024

Description

This PR provides a useful current_parent_* scope when adding and editing child features through the attribute form's relation editor widget.

For feature addition, it comes in extremely handy when the parent feature is also being added. In this case, the parent feature itself can't be retrieved (since it hasn't even been added to the edit buffer), nor can its attributes or geometry.

Fixes #48915.

@nirvn nirvn added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Feature labels Apr 29, 2024
@github-actions github-actions bot added this to the 3.38.0 milestone Apr 29, 2024
@uclaros
Copy link
Contributor

uclaros commented Apr 29, 2024

Does this fix #48915 then? (... and also properly fix #40194 ?)

@nirvn nirvn changed the title Current parent [attribute form] Add parent feature scope when adding/editing a child featur through the relation editor widget Apr 29, 2024
@nirvn nirvn removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Apr 29, 2024
@nirvn
Copy link
Contributor Author

nirvn commented Apr 30, 2024

@uclaros , it does implement what's requested in #48915 yes :)

@nirvn nirvn closed this Apr 30, 2024
@nirvn nirvn reopened this Apr 30, 2024
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 15, 2024
@nyalldawson nyalldawson added the Freeze Exempt Feature Freeze exemption granted label May 17, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Freeze Exempt Feature Freeze exemption granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable opportunities to get unsaved data of parent features in child-features
3 participants