Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted set of fixes related to DateTime Z formatter #57483

Merged
merged 4 commits into from
May 22, 2024

Conversation

rouault
Copy link
Contributor

@rouault rouault commented May 18, 2024

I'm perhaps missing something but it seems Qt cannot handle the Z formatter and doesn't automatically perform conversion to UTC when the input datetime is in another time spec.

@github-actions github-actions bot added this to the 3.38.0 milestone May 18, 2024
Copy link

github-actions bot commented May 19, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7a2c34c)

@nyalldawson
Copy link
Collaborator

These incremental changes look good to me.

(I do think we need a bigger rework of time zones at some stage, eg having some method to allow the utc datetime values in a GPKG to always be shown to the user in local time. )

@nyalldawson nyalldawson merged commit 9b3d206 into qgis:master May 22, 2024
30 checks passed
@nyalldawson
Copy link
Collaborator

@rouault should we backport this?

@rouault
Copy link
Contributor Author

rouault commented May 22, 2024

@rouault should we backport this?

I'm kind of nervous, as I'm not totally sure this will not cause backward compatibility problems.
For ex in #57262, the user specified a default value as format_date(datetime_from_epoch(epoch(now())+3600000*4),'yyyy-MM-ddTHH:mm:ssZ'), with probably the intent to shift its local time by 4 hours and have that computed value directly considered as UTC. Now this will convert that computed value (its local time + 4 hours) to UTC.

The commit in the OGR provider should be OK to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants