Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.UnsupportedOperation: fileno #970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

66hh
Copy link

@66hh 66hh commented Oct 30, 2021

使用IDLE时fileno函数会引发异常导致整个模块无法使用

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


使用IDLE时fileno函数会引发异常导致整个模块无法使用
@elicn
Copy link
Member

elicn commented Oct 31, 2021

I am not sure we support running Qiling from an interactive Python interpreter.. I'll leave it to the others comment.
Mean while, I would prefer a code change to be a little bit explanatory about what was the change and why (putting a vague exception name int he comments without a proper context doesn't help much...).

What about surrounding the problematic code with the appropriate try / catch and add comments it's for woroking around IDLE exceptions..?

@xwings
Copy link
Member

xwings commented Oct 31, 2021

First,

base is still master. always pr to dev

i never use IDLE, not too sure will it even break the stdio. i guess @kabeor or @wtdcode know more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants