Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean warnings in build #1327

Merged
merged 3 commits into from Aug 10, 2023
Merged

chore: clean warnings in build #1327

merged 3 commits into from Aug 10, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Aug 9, 2023 •
edited

Motivation

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

Caele
Caele commented Aug 9, 2023
View reviewed changes
apis/nucleus/src/sn/type.js
import extend from 'extend';
import satisfies from 'semver/functions/satisfies';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an attempt to solve the circular dependency warning detailed here: npm/node-semver#381
Still get the warning however.

@Caele Caele marked this pull request as ready for review August 9, 2023 11:10
@Caele Caele requested a review from a team August 9, 2023 11:10
@Caele Caele merged commit 1203059 into master Aug 10, 2023
18 checks passed
@Caele Caele deleted the tsm/clean-warnings branch August 10, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Caele