Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fkd/lasso circle selection #38

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

VasilisKalaitzis
Copy link
Collaborator

@VasilisKalaitzis VasilisKalaitzis commented Dec 2, 2022

Ready for verification checklist

Please make sure to go through the list below before adding reviewers.
If some checks aren't done, you can create a draft PR until they are.

  • Resolve conflicts
  • Unit tests
  • Manual verification

Summary

This PR adds the selection functionality with circle and lasso.

Left ToDo:

  • During selection, add the ability to switch between layers (currently not supported by nebula)
  • Unit tests
  • (Optional) I personally don't like to have multiple function that changes the class' state. Maybe the selection-model/index.ts can become a little cleaner by not having so many (a) state variables or (b) so many functions that changes the state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant