Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

chore: enable system js build #746

Merged
merged 2 commits into from Nov 22, 2022
Merged

chore: enable system js build #746

merged 2 commits into from Nov 22, 2022

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Nov 21, 2022

Updates the Nebula dependency and enables the systemJS build artifact.

@Caele Caele requested a review from haxxmaxx November 21, 2022 12:06
@Caele
Copy link
Collaborator Author

Caele commented Nov 22, 2022

Had to leave nebula/cli-build at 3.0.3 due to an update to @rollup/plugin-node-resolve v14 which somehow breaks the table in particular.
The Nebula PR is this: qlik-oss/nebula.js#946
The change in @rollup/plugin-node-resolve is rollup/plugins#1245
I have yet to determine what actually happens and how to resolve it.

The actual error:

---> BUILDING SUPERNOVA
No name was provided for external module “stream” in “output.globals” – guessing “require$$7$1”.
Creating a browser bundle that depends on Node.js built-in modules (“stream”). You might need to include https://github.com/FredKSchott/rollup-plugin-polyfill-node

@Caele Caele merged commit 15714bb into main Nov 22, 2022
@Caele Caele deleted the tsm/systemjs branch November 22, 2022 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants