Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macha60 pcb firmware #23647

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

add macha60 pcb firmware #23647

wants to merge 79 commits into from

Conversation

CMMS-Freather
Copy link
Contributor

@CMMS-Freather CMMS-Freather commented May 2, 2024

add macha60 pcb firmware

Description

a 60% with exploded 7u spacebar

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

CMMS-Freather and others added 30 commits September 28, 2023 21:53
adding fuji75 pcb support
includes
solder
hotswap
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
update info.json per requested by @fauxpark
reran qmk format-json
adding haven60 firmware
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
CMMS-Freather and others added 10 commits March 19, 2024 14:56
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
adding macha60/pegasus60 firmware, small gb made with exploded 7u spacebar
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 2, 2024
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of your own sanity, you probably want to read through some of the git advice in QMK's documentation.

In particular: Your Fork’s Master: Update Often, Commit Never.

Additionally: after making changes to keyboards/macha60/info.json, run qmk format-json -i keyboards/macha60/info.json to reformat it.

keyboards/macha60/info.json Outdated Show resolved Hide resolved
keyboards/macha60/config.h Outdated Show resolved Hide resolved
keyboards/macha60/info.json Outdated Show resolved Hide resolved
keyboards/macha60/macha60.c Outdated Show resolved Hide resolved
keyboards/macha60/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/macha60/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/macha60/readme.md Outdated Show resolved Hide resolved
keyboards/macha60/info.json Outdated Show resolved Hide resolved
keyboards/macha60/readme.md Show resolved Hide resolved
keyboards/macha60/readme.md Show resolved Hide resolved
CMMS-Freather and others added 6 commits May 3, 2024 03:34
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other unresolved suggestions should also be completed.

keyboards/macha60/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/macha60/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/macha60/info.json Outdated Show resolved Hide resolved
keyboards/macha60/macha60.c Outdated Show resolved Hide resolved
CMMS-Freather and others added 3 commits May 3, 2024 18:34
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
@CMMS-Freather CMMS-Freather requested a review from zvecr May 5, 2024 14:53
@zvecr
Copy link
Member

zvecr commented May 5, 2024

The other unresolved suggestions should also be completed.

There is little point requesting a review, as there are at least 6 unresolved suggestions/comments still.

Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;e

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run qmk format-json on this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants