Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add farsi keymap extras #23650

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

add farsi keymap extras #23650

wants to merge 4 commits into from
+788 −0

Conversation

ahmafi
Copy link

@ahmafi ahmafi commented May 2, 2024 •
edited

Description

Add a keymap_extras mapping for Farsi (Persian). There are a few layouts for Persian, and this is for the standard layout which is more common.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core documentation dd Data Driven Changes labels May 2, 2024
@drashna drashna requested review from fauxpark and a team May 19, 2024 04:54
fauxpark
fauxpark requested changes May 21, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate keycodes should be removed. Prefer the least-modified one, and from left to right, top to bottom.

data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson Show resolved Hide resolved
@ahmafi ahmafi requested a review from fauxpark May 24, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@zvecr zvecr zvecr left review comments

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
core dd Data Driven Changes documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmafi @drashna @fauxpark @zvecr