Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Typface Univers #23664

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

itsme-zeix
Copy link
Contributor

Description

Added support for Typface Univers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 5, 2024
Copy link
Contributor

@dunk2k dunk2k May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. F4 and 2u Backspace keys are labelled with the same matrix co-ordinate, could this be corrected?
  2. For all keys in diagram, could right hand co-ordinate be changed from A-N to 0-9,A-E? as to be in uniform with other matrix_diagram.md files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I will correct it. Thanks for the review!

keyboards/zeix/typface/univers/rules.mk Outdated Show resolved Hide resolved
itsme-zeix and others added 2 commits May 5, 2024 20:27
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@drashna drashna requested a review from a team May 19, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants