Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Reference advance keycodes in combos #23666

Merged
merged 1 commit into from May 19, 2024
Merged

[Doc] Reference advance keycodes in combos #23666

merged 1 commit into from May 19, 2024

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented May 5, 2024 •
edited

Description

Mention support of advance keycodes that are not just limited to mod-tap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@filterpaper filterpaper force-pushed the update-combo-doc branch 2 times, most recently from a8c27eb to 90ca526 Compare May 5, 2024 11:33
@filterpaper
[Doc] Reference advance keycodes in combos
cae537f 
Mention support of advance keycodes that are not just limited to mod-tap.
@waffle87 waffle87 requested a review from a team May 15, 2024 04:23
@drashna drashna merged commit dd56bee into qmk:master May 19, 2024
2 checks passed
@filterpaper filterpaper deleted the update-combo-doc branch May 19, 2024 04:58
oni-Sk pushed a commit to oni-Sk/qmk_firmware that referenced this pull request May 19, 2024
@filterpaper @oni-Sk
[Doc] Reference advance keycodes in combos (qmk#23666)
8c3afc6
Coko7 pushed a commit to Coko7/qmk_firmware that referenced this pull request May 20, 2024
@filterpaper @Coko7
[Doc] Reference advance keycodes in combos (qmk#23666)
550f678
aaruff pushed a commit to aaruff/qmk_firmware that referenced this pull request May 22, 2024
@filterpaper @aaruff
[Doc] Reference advance keycodes in combos (qmk#23666)
b51da77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@filterpaper @drashna @waffle87 @dunk2k