add tercy/rev004 #23687

TercyKB · 2024-05-09T06:34:17Z

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

lesshonor · 2024-05-09T13:54:00Z

keyboards/tercy/rev004/keymaps/default/keymap.c

+typedef union {
+  uint32_t raw;
+  struct {
+    bool     rgb_layer_change :1;
+  };
+} user_config_t;
+
+user_config_t user_config;
+
+layer_state_t layer_state_set_user(layer_state_t state) {
+    return update_tri_layer_state(state, 1, 2, 3);
+}
+


This keyboard doesn't appear to have RGB, and these are the default settings for tri-layer (so they are redundant)

Suggested change

typedef union {

uint32_t raw;

struct {

bool rgb_layer_change :1;

};

} user_config_t;

user_config_t user_config;

layer_state_t layer_state_set_user(layer_state_t state) {

return update_tri_layer_state(state, 1, 2, 3);

}

lesshonor · 2024-05-09T13:54:27Z

keyboards/tercy/rev004/info.json

+    "manufacturer": "Tercy",
+    "keyboard_name": "Tercy_rev004",
+    "maintainer": "Tercy",
+    "bootloader": "caterina",


Suggested change

"bootloader": "caterina",

"development_board": "promicro",

lesshonor · 2024-05-09T13:54:51Z

keyboards/tercy/rev004/info.json

+        "cols": ["D4", "C6", "F4", "F5", "F6", "F7"],
+        "rows": ["B1", "B3", "B2", "B6", "D7", "E6", "B4", "B5"]
+    },
+    "processor": "atmega32u4",


Setting development_board handles this.

Suggested change

"processor": "atmega32u4",

lesshonor · 2024-05-09T13:55:11Z

keyboards/tercy/rev004/info.json

+        "command": false,
+        "console": false,


These settings are not enabled by default, so there is no need to explicitly disable them here.

Suggested change

"command": false,

"console": false,

lesshonor · 2024-05-09T13:55:50Z

keyboards/tercy/rev004/info.json

+        "console": false,
+        "extrakey": true,
+        "mousekey": true,
+        "nkro": true


Suggested change

"nkro": true

"nkro": true,

"tri_layer": true

lesshonor · 2024-05-09T14:03:56Z

keyboards/tercy/rev004/keymaps/via/keymap.c

+typedef union {
+  uint32_t raw;
+  struct {
+    bool     rgb_layer_change :1;
+  };
+} user_config_t;
+
+user_config_t user_config;
+
+layer_state_t layer_state_set_user(layer_state_t state) {
+    return update_tri_layer_state(state, 1, 2, 3);
+}
+


See previous comment on default keymap.

Suggested change

typedef union {

uint32_t raw;

struct {

bool rgb_layer_change :1;

};

} user_config_t;

user_config_t user_config;

layer_state_t layer_state_set_user(layer_state_t state) {

return update_tri_layer_state(state, 1, 2, 3);

}

lesshonor · 2024-05-09T14:04:26Z

keyboards/tercy/rev004/keymaps/via/keymap.c

+    ),
+    [4] = LAYOUT(
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO
+    ),
+    [5] = LAYOUT(
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO
+    ),
+    [6] = LAYOUT(
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO
+    ),
+    [7] = LAYOUT(
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,
+        KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO,   KC_NO


See previous comment on default keymap.

Suggested change

),

[4] = LAYOUT(

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO

),

[5] = LAYOUT(

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO

),

[6] = LAYOUT(

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO

),

[7] = LAYOUT(

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,

KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO

lesshonor · 2024-05-09T14:04:51Z

keyboards/tercy/rev004/readme.md

+![tercy](imgur.com image replace me!)
+
+*A short description of the keyboard/project*


Please fill these out.

lesshonor · 2024-05-09T14:05:02Z

keyboards/tercy/rev004/readme.md

+* Hardware Supported: *The PCBs, controllers supported*
+* Hardware Availability: *Links to where you can find this hardware*


Please provide information.

lesshonor · 2024-05-09T14:06:18Z

keyboards/tercy/rev004/info.json

After making changes, please run qmk format-json -i keyboards/tercy/rev004/info.json.

Thank you so much for your polite review.
I learned a lot from your suggestions.
I realized that I had not understanded the source code I refered.
Qmk_firmware requires less codes, it is wonderfull!!

I need time to read the PR Checklist and the CONTRIBUTING document.
I will fix readme.md after that.

TercyKB · 2024-05-15T01:08:53Z

I enabled the PCB data to be downloaded for hardware availability, and updated readme.md.
Please review the PR again.
Thank you.

keyboards/tercy/rev004/readme.md

add tercy/rev004

8a34eae

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 9, 2024

zvecr added the pr_checklist_pending Needs changes as per the PR checklist label May 9, 2024

tadashi added 4 commits May 9, 2024 22:08

Fixed lint error.

aa78725

Fixed license headers.

362dcec

Fixed license headers.

682cdd6

Deleted unnecessary files.

dc6ed79

lesshonor suggested changes May 9, 2024

View reviewed changes

tadashi added 2 commits May 10, 2024 00:41

Refined source codes with sugguestions.

479f27c

Updated readme.md

3bff768

TercyKB requested a review from lesshonor May 15, 2024 01:11

drashna reviewed May 18, 2024

View reviewed changes

keyboards/tercy/rev004/readme.md Outdated Show resolved Hide resolved

Updated image url from a blog to the imgur

8a0e25d

drashna approved these changes May 19, 2024

View reviewed changes

zvecr removed the pr_checklist_pending Needs changes as per the PR checklist label May 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add tercy/rev004 #23687

add tercy/rev004 #23687

TercyKB commented May 9, 2024 •

edited

lesshonor May 9, 2024

lesshonor May 9, 2024

lesshonor May 9, 2024

lesshonor May 9, 2024

lesshonor May 9, 2024

lesshonor May 9, 2024

lesshonor May 9, 2024

lesshonor May 9, 2024

lesshonor May 9, 2024

lesshonor May 9, 2024

TercyKB May 9, 2024

TercyKB commented May 15, 2024

		![tercy](imgur.com image replace me!)

		A short description of the keyboard/project

		* Hardware Supported: The PCBs, controllers supported
		* Hardware Availability: Links to where you can find this hardware

add tercy/rev004 #23687

Are you sure you want to change the base?

add tercy/rev004 #23687

Conversation

TercyKB commented May 9, 2024 • edited

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TercyKB commented May 15, 2024

TercyKB commented May 9, 2024 •

edited