Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PS/2 Trackpoint mouse clicks (#22265) #23694

Merged
merged 2 commits into from May 20, 2024
Merged

Fix PS/2 Trackpoint mouse clicks (#22265) #23694

merged 2 commits into from May 20, 2024

Conversation

strobo5
Copy link
Contributor

@strobo5 strobo5 commented May 11, 2024

Description

Bug report #22265 and fix by d93921012, I'm just pushing the change. There is a longer description the bug report; shorter summary:

When the main loop calls ps2_mouse_task() for the first time after the button down event, it finds no new data in the PS/2 receive buffer. Here it should return, or it tries to detect a button state change anyway and updates the mouse state with the button released before it is actually released. When doing click and drag, it cycles between button down and up.

Tested on ARM ChibiOS (RP2040) with a Trackpoint from a Thinkpad T61. With this change it works perfectly. The keyboard itself is a home-made converter for the Thinkpad keyboard (only in my personal fork at this point).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Bug report and fix by d93921012, I'm just pushing the change.

Tested on ARM ChibiOS (RP2040) with a Trackpoint from a Thinkpad T61.
@github-actions github-actions bot added the core label May 11, 2024
@zvecr zvecr requested a review from a team May 17, 2024 21:46
@drashna
Copy link
Member

drashna commented May 20, 2024

This also should probably be targeting the develop branch.

@zvecr zvecr changed the base branch from master to develop May 20, 2024 23:34
@zvecr zvecr added the bug label May 20, 2024
@zvecr
Copy link
Member

zvecr commented May 20, 2024

Bugfix, so it could go directly to master however theres no harm in it going to develop given the cycles timeframe.

@zvecr zvecr merged commit a850f7d into qmk:develop May 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Trackpoint work improperly in Interrupt Version (ARM chibios) PS/2 Mouse Support
3 participants