Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for inverted SPI CS logic #23699

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Allow for inverted SPI CS logic #23699

wants to merge 4 commits into from
+53 −22

Conversation

daskygit
Copy link
Member

Description

Not fully tested, opened for feedback/visibility.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@daskygit daskygit changed the base branch from master to develop May 11, 2024 15:44
@github-actions github-actions bot added core keyboard keymap documentation translation via Adds via keymap and/or updates keyboard for via support CI dd Data Driven Changes labels May 11, 2024
@daskygit daskygit removed keyboard keymap documentation translation via Adds via keymap and/or updates keyboard for via support CI dd Data Driven Changes labels May 11, 2024
sigprof
sigprof requested changes May 11, 2024
View reviewed changes
platforms/avr/drivers/spi_master.c Outdated Show resolved Hide resolved
platforms/avr/drivers/spi_master.h Outdated Show resolved Hide resolved
platforms/avr/drivers/spi_master.h Outdated Show resolved Hide resolved
platforms/chibios/drivers/spi_master.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprof sigprof sigprof requested changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daskygit @sigprof