Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RGB color override and brightness for EC Type K #23703

Merged
merged 1 commit into from May 13, 2024

Conversation

Cipulot
Copy link
Contributor

@Cipulot Cipulot commented May 12, 2024

Description

This fix has 2 changes:

  • change of max brightness from 200 to 175
  • addition of rgblight_set() in indicator handling

The first is to remain within the 500mA current limit.

The second addresses an issue I encountered when setting static light mode in the RGB effects.
Before the addition, I was tricked into thinking that the code was correct because the behavior was normal in modes like Swirl and similar.
The issue tho was that the bypass of the color set was managed by the effect manager instead of myself, making me believe that the colors for indicators were updated as I called them.
Re reading through docs tho made me realize that this is not the case and I had to add that line to correctly apply the color set.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nooges nooges changed the title Fix for RGB color override and brightness Fix for RGB color override and brightness for EC Type K May 13, 2024
@waffle87 waffle87 merged commit fcbbaf4 into qmk:master May 13, 2024
3 checks passed
Coko7 pushed a commit to Coko7/qmk_firmware that referenced this pull request May 20, 2024
aaruff pushed a commit to aaruff/qmk_firmware that referenced this pull request May 22, 2024
@Cipulot Cipulot deleted the fix_ec_typek branch May 25, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants