Fix for RGB color override and brightness for EC Type K #23703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix has 2 changes:
200
to175
rgblight_set()
in indicator handlingThe first is to remain within the 500mA current limit.
The second addresses an issue I encountered when setting static light mode in the RGB effects.
Before the addition, I was tricked into thinking that the code was correct because the behavior was normal in modes like Swirl and similar.
The issue tho was that the bypass of the color set was managed by the effect manager instead of myself, making me believe that the colors for indicators were updated as I called them.
Re reading through docs tho made me realize that this is not the case and I had to add that line to correctly apply the color set.
Types of Changes
Issues Fixed or Closed by This PR
Checklist