Models

[pontaoski]

This PR implements the minimum recommended APIs necessary to implement read-only models in C# that can interop with QML, handling 90% of usecases for models.

Depends on qmlnet/qmlnet-native#1.

[pontaoski]

Ping?

[pauldotknopf]

Oh, sorry, I didn't realize this was ready for review. I will try to get to it this week, this weekend at the latest.

[pauldotknopf]

It's not required on your part, but if you have time, I'd like to see some unit tests that both test and demonstrate what you've done.

By the way, good work!

[pauldotknopf]

It looks like the native code is failing a build on Windows.

[pauldotknopf]

NetAbstractItemModelRoleNames.cpp
..\QmlNet\QmlNet\qml\NetAbstractItemModelRoleNames.cpp(3): error C7555: use of designated initializers requires at least '/std:c++latest'
..\QmlNet\QmlNet\qml\NetQModelIndex.cpp(7): error C7555: use of designated initializers requires at least '/std:c++latest'
..\QmlNet\QmlNet\qml\NetQModelIndex.cpp(12): error C7555: use of designated initializers requires at least '/std:c++latest'
NetAbstractItemModel.cpp
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(87): warning C4100: 'idx': unreferenced formal parameter
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(94): warning C4100: 'idx': unreferenced formal parameter
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(7): error C7555: use of designated initializers requires at least '/std:c++latest'
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(43): warning C4190: 'net_abstract_item_model_get_flags' has C-linkage specified, but returns UDT 'std::function<int (ModelIdx)>' which is incompatible with C
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(13): note: see declaration of 'std::function<int (ModelIdx)>'
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(44): warning C4190: 'net_abstract_item_model_get_data' has C-linkage specified, but returns UDT 'std::function<Variant (ModelIdx,int)>' which is incompatible with C
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(16): note: see declaration of 'std::function<Variant (ModelIdx,int)>'
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(45): warning C4190: 'net_abstract_item_model_get_header_data' has C-linkage specified, but returns UDT 'std::function<Variant (int,int,int)>' which is incompatible with C
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(19): note: see declaration of 'std::function<Variant (int,int,int)>'
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(46): warning C4190: 'net_abstract_item_model_get_row_count' has C-linkage specified, but returns UDT 'std::function<int (ModelIdx)>' which is incompatible with C
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(13): note: see declaration of 'std::function<int (ModelIdx)>'
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(47): warning C4190: 'net_abstract_item_model_get_column_count' has C-linkage specified, but returns UDT 'std::function<int (ModelIdx)>' which is incompatible with C
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(13): note: see declaration of 'std::function<int (ModelIdx)>'
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(48): warning C4190: 'net_abstract_item_model_get_index' has C-linkage specified, but returns UDT 'std::function<ModelIdx (int,int,ModelIdx)>' which is incompatible with C
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(28): note: see declaration of 'std::function<ModelIdx (int,int,ModelIdx)>'
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(49): warning C4190: 'net_abstract_item_model_get_parent' has C-linkage specified, but returns UDT 'std::function<ModelIdx (ModelIdx)>' which is incompatible with C
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(31): note: see declaration of 'std::function<ModelIdx (ModelIdx)>'
..\QmlNet\QmlNet\qml\NetAbstractItemModel.cpp(50): warning C4190: 'net_abstract_item_model_get_role_names' has C-linkage specified, but returns UDT 'std::function<NetHashTypeContainer *(void)>' which is incompatible with C
C:\projects\qmlnet\src\native\QmlNet\QmlNet\qml\NetAbstractItemModel.h(34): note: see declaration of 'std::function<NetHashTypeContainer *(void)>'
Generating Code...
jom: C:\projects\qmlnet\src\native\build\Makefile.Release [release\NetQModelIndex.obj] Error 2
jom: C:\projects\qmlnet\src\native\build\Makefile.Release [release\NetAbstractItemModelRoleNames.obj] Error 2
jom: C:\projects\qmlnet\src\native\build\Makefile [release-install] Error 2

[pontaoski]

qmlnet/qmlnet-native#2.

[pauldotknopf]

Merged.

[pontaoski]

looks like this builds now

[vadi2]

How does this change the API of working with models?

[pontaoski]

How does this change the API of working with models?

This exposes the usual slew of Qt model classes, which allows them to be used from C#. I would recommend reading Qt docs: https://doc.qt.io/qt-5/model-view-programming.html

[vadi2]

I've been using those for a decade so I'm pretty familiar, but there is no documentation here - add examples how it would look?

[pontaoski]

I've been using those for a decade so I'm pretty familiar, but there is no documentation here - add examples how it would look?

doc comments added

[vadi2]

thank you