Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer: make parent not read-only for now #381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Dec 31, 2016

Some parts of QmlWeb set .parent property directly, that was causing a
conflict and an exception was being thrown.

Long-term, we should create a better fix, but this fixes the immediate
problem for now, and properties not being read-only when they should
causes much less damage than unexpected exceptions on valid qml code.

This still need a testcase.

Some parts of QmlWeb set .parent property directly, that was causing a
conflict and an exception was being thrown.

Long-term, we should create a better fix, but this fixes the immediate
problem for now, and properties not being read-only when they should
causes much less damage than unexpected exceptions on valid qml code.
@stephenmdangelo
Copy link
Member

I have this fix on a branch of mine that solves the issue for QObject.$delete. Are there other places you're seeing an exception being thrown for Timer?

stephenmdangelo@d20d820

@ChALkeR
Copy link
Member Author

ChALkeR commented Jan 3, 2017

@stephenmdangelo Thanks! I will test that commit soon (hopefully today) and will tell you if that works for my original testcase that was failing (it's not a minimal testcase yet).

@ChALkeR
Copy link
Member Author

ChALkeR commented Jul 30, 2017

@stephenmdangelo Full grep:

src/modules/QtQuick/Item.js:        child.parent = this; // This will also add it to children.
src/modules/QtQuick/Repeater.js:    this.parent = meta.parent;
src/modules/QtQuick/Repeater.js:      newItem.parent = this.parent;
src/modules/QtQuick/Loader.js:    qmlComponent.parent = this;
src/modules/QtQuick/Loader.js:    this.item.parent = undefined;
src/modules/QtQuick.Controls/ScrollView.js:      newItem.parent = this;
src/qtbase/QObject.js:    this.parent = undefined;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ChALkeR's personal shortlist
  
In progress / Has PR
Development

Successfully merging this pull request may close these issues.

None yet

2 participants