1 div per Rectangle, Behaviors working smoothly, fix crash IE when re… #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gister class directly for Animation and Behavior, added ColorAnimation, added Grid column and row spacings, text font update, removed warning when ignoreUnkownSignals for Connections, TextInput without rect rendering, MouseArea press and release signals, added Item horizontal and vertical center offsets
ChALkeR
reviewed
Feb 9, 2018
| @@ -9,13 +9,15 @@ QmlWeb.registerQmlType({ | |||
| hoverEnabled: "bool", | |||
| mouseX: "real", | |||
| mouseY: "real", | |||
| pressed: "bool", | |||
| isPressed: "bool", | |||
There was a problem hiding this comment.
Why this change? Property is named pressed in QML
ChALkeR
reviewed
Feb 9, 2018
| containsMouse: "bool", | ||
| pressedButtons: { type: "variant", initialValue: 0 }, | ||
| cursorShape: "enum" // Qt.ArrowCursor | ||
| }, | ||
| signals: { | ||
| clicked: [{ type: "variant", name: "mouse" }], | ||
| pressed: [{ type: "variant", name: "mouse" }], |
There was a problem hiding this comment.
Ah, to have an onPressed signal…
Hm, looks like there is a confict currently for elements that have properties and signals under the same name.
Will look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 div per Rectangle, Behaviors working smoothly, roll back registering class directly for Animation and Behavior - crashing on IE, added ColorAnimation (from Gaubee), added Grid column and row spacings, text font update - class QFont not emitting signal change, dont' print warning when ignoreUnkownSignals for Connections, TextInput transparent rect rendering as in QML, MouseArea press and release signals, added Item horizontal and vertical center offsets.